Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(command-not-found): nix command suggestions #214

Merged
merged 2 commits into from
Jun 14, 2023
Merged

fix(command-not-found): nix command suggestions #214

merged 2 commits into from
Jun 14, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Jun 13, 2023

closes #185

@figsoda figsoda mentioned this pull request Jun 13, 2023
Closed
emilazy
emilazy reviewed Jun 13, 2023
View reviewed changes
Copy link

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it'd be good to include the command name after -c? (I guess this applies to the nix-shell case too.)

@figsoda figsoda merged commit 2bb4d35 into nix-community:master Jun 14, 2023
1 check passed
@figsoda figsoda deleted the cnf branch June 14, 2023 15:06
@doronbehar
Copy link
Contributor

The issue fixed here has annoyed me for a while now... Is there a chance for a new release? 🙏

@figsoda
Copy link
Member Author

figsoda commented Aug 7, 2023

@bennofs would you mind if I cut a new release?

@figsoda
Copy link
Member Author

figsoda commented Aug 16, 2023 •
edited
Loading

@nix-community/nix-index any objections before I create a new release?

@bennofs
Copy link
Collaborator

bennofs commented Aug 21, 2023

No objections. Release process is as follows:

  1. Update changelog
  2. Create annotated tag with changes for releases (git tag -a, see prev tags)
  3. Create release on github for this tag
  4. Publish release to crates.io
  5. Bump version and prepare empty changelog for next release

@figsoda
Copy link
Member Author

figsoda commented Aug 21, 2023

4. Publish release to crates.io

Do you mind adding me to the owners of the crate? Or would you prefer to publish the crate release yourself?

@bennofs
Copy link
Collaborator

bennofs commented Aug 22, 2023

I can add you if you tell me your nicks on crates.io

@figsoda
Copy link
Member Author

figsoda commented Aug 22, 2023

figsoda (same as github)

@figsoda
Copy link
Member Author

figsoda commented Aug 23, 2023

Thanks for the invite, I'll do a release soon

@figsoda
Copy link
Member Author

figsoda commented Aug 24, 2023

0.1.7 has been released 🎉

@doronbehar
Copy link
Contributor

For reference https://nixpk.gs/pr-tracker.html?pr=251199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

command-not-found prints out wrong nix run command
4 participants
@figsoda @doronbehar @bennofs @emilazy