Add possibility to use fakedroid from outside the repo #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t184256
reviewed
Jul 14, 2023
| @@ -38,4 +38,5 @@ pkgs.runCommand | |||
| --subst-var-by prootTest "${bootstrap.customPkgs.prootTermuxTest}" \ | |||
| --subst-var-by installationDir "${bootstrap.config.build.installationDir}" \ | |||
| --subst-var-by homeDir "${bootstrap.config.user.home}" \ | |||
| --subst-var-by flakeRootDir "${toString ../.}" | |||
There was a problem hiding this comment.
Will that make fakedroid ignore uncommitted changes and always build environment from the commit it itself is built from?
There was a problem hiding this comment.
It will build with all changes tracked by git. Behaves the same as every other interaction with flakes in git repositories.
|
Seems to work OK. Not sure I'm a fan of it always using the repo/commit it's built from, hope it won't bring confusion. |
|
I tried to find a solution to keep the current behaviour but couldn't find a way.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #274