Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake.nix: expose nix-on-droid package in overlay #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pinage404
Copy link
Contributor

No description provided.

@t184256
Copy link
Collaborator

t184256 commented Jul 14, 2024

what's the point of that? what usage does it help with?

@pinage404
Copy link
Contributor Author

When using the nix-on-droid's overlay like in the advanced template

nix-on-droid.overlays.default

It allows to install the package with a normal pkgs.nix-on-droid instead of inputs.nix-on-droid.packages."${system}".nix-on-droid

@t184256
Copy link
Collaborator

t184256 commented Jul 14, 2024

but it is installed by default... I don't get it

@pinage404
Copy link
Contributor Author

it can be usefull if we want to use nix-on-droid on another platform

i'm trying to write a deployment script, i use it

@t184256
Copy link
Collaborator

t184256 commented Jul 14, 2024

  1. why use that imperative tool from another platform; it's meant to be run on the target device
  2. in this case, accessing it from an overlay only makes it harder, doesn't it?

@pinage404
Copy link
Contributor Author

  1. my computer is more powerful than my phone, i would like to build on my computer (and check if all is good) instead of pushing, on my phone waiting the long evalution, then see that it fails after a long delay
  2. i prefer to add the overlay in one place than writing inputs.nix-on-droid.packages."${system}".nix-on-droid everywhere i need nix-on-droid

@t184256
Copy link
Collaborator

t184256 commented Jul 14, 2024

sorry, good, but where do you need it at all? how many places is that, what are they?

@pinage404
Copy link
Contributor Author

i haven't finished my script (the feedback loop is super long) for the moment, i need it in 2 places

If you believe, that is not a good thing, i can close this PR

@t184256
Copy link
Collaborator

t184256 commented Jul 14, 2024

I don't know, I need to weigh pros and cons of exposing it this way. Once I do that, it'd be hard to remove it back + I'm not sure what's the behaviour of overriding it in an overlay is etc. etc. Not something I can decide on quickly.

@shelvacu
Copy link

my computer is more powerful than my phone, i would like to build on my computer (and check if all is good)

FYI @pinage404 if you use flakes you can build on your computer with nix build .#nixOnDroidConfigurations.default.activationPackage --impure

@pinage404
Copy link
Contributor Author

@t184256
Copy link
Collaborator

t184256 commented Jul 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants