-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ms-vscode.cpptools has rolled back to an old version (1.7.1 instead of 1.20.0) #61
Comments
I think this is exactly what is happening. The sort is textual. I'll see how to fix this. |
@deemp Would you accept the introduction of this type? It seems like the implementation of |
@FraGag, I believe the problem is fixed now.
|
@yacinehmito, I used versions and I liked that package :) |
I confirm the issue is fixed. Thanks! |
I detected this issue because for some extensions, I'm using the derivation from upstream nixpkgs but the extension versions from nix-vscode-extensions. I'm running NixOS so I need the patches from nixpkgs for these extensions to work, but nixpkgs is slow to update VSCode extensions, so I use nix-vscode-extensions to get updates more frequently. (Yes, this setup tends to break often.)
Since commit 9a610ee, the flake exposes version 1.7.1 of ms-vscode.cpptools instead of 1.20.0 on x86_64-linux:
I noticed that in
data/cache/vscode-marketplace-latest.json
, there's a line for 1.7.1 of ms-vscode.cpptools for the "universal" platform, and in commit 9a610ee, it moved from before the more recent platform-specific lines to after them.Looking at earlier commits, it appears the change is intentional:
However, it doesn't appear to be working as expected. Perhaps a version sort is not implemented correctly somewhere and it thinks 1.7.1 is more recent than 1.20.0? (A naïve textual sort would indeed claim so.)
cc @yacinehmito, @deemp
The text was updated successfully, but these errors were encountered: