Make version takes precedence over platform #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of extension info is important because it dictates which extension is resolved when multiple revisions exist for the same name and same publisher. At the moment, extensions are first sorted by platform, then by version. This makes any platform-specific extension override a universal extension of the same name and publisher, even if the platform-specific extension is of a lower version. Sorting by version first ensures that extensions of the latest version end up last. Thus, if there is a universal extension of a higher version then a platform-specific extension, the universal extension will take precedence. However, if they are of the same version, the behavior is unchanged: the platform-specific extension will take precedence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of extension info is important because it dictates which extension is resolved when multiple revisions exist for the same name and same publisher.
At the moment, extensions are first sorted by platform, then by version. This makes any platform-specific extension override a universal extension of the same name and publisher, even if the platform-specific extension is of a lower version.
Sorting by version first ensures that extensions of the latest version end up last. Thus, if there is a universal extension of a higher version then a platform-specific extension, the universal extension will take precedence. However, if they are of the same version, the behavior is unchanged: the platform-specific extension will take precedence.
Fixes #58.