Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subshell the hook so that it doesn't pollute the wrapping env #45

Closed
blaggacao opened this issue Jul 30, 2022 · 0 comments · Fixed by #46 · May be fixed by #31
Closed

Subshell the hook so that it doesn't pollute the wrapping env #45

blaggacao opened this issue Jul 30, 2022 · 0 comments · Fixed by #46 · May be fixed by #31

Comments

@blaggacao
Copy link
Contributor

The shell hook currently doesn't clean up things like debug() after itself.

However, the hook might be embedded into an environment that already has taken a different contract on something like debug().

Hence, encapsulate the hook and clean up after itself!
blaggacao added a commit to blaggacao/nixago that referenced this issue Jul 30, 2022
@blaggacao
fix: don't leave traces in the hook's environment
2667229 
fixes: nix-community#45
@blaggacao blaggacao mentioned this issue Jul 30, 2022
Merged
blaggacao added a commit to blaggacao/nixago that referenced this issue Jul 30, 2022
@blaggacao
fix: don't leave traces in the hook's environment
e6c15fa 
fixes: nix-community#45
blaggacao added a commit to blaggacao/nixago that referenced this issue Jul 30, 2022
@blaggacao
fix: don't leave traces in the hook's environment
7bd72b0 
fixes: nix-community#45
@blaggacao blaggacao changed the title subshell the hook so that it doesn't pollute the wrapping env Subshell the hook so that it doesn't pollute the wrapping env Jul 30, 2022
@blaggacao blaggacao mentioned this issue Jul 30, 2022
Merged
jmgilman pushed a commit that referenced this issue Jul 30, 2022
@blaggacao
fix: don't leave traces in the hook's environment (#46)
21272c3 
fixes: #45
@github-actions github-actions bot mentioned this issue Jul 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@blaggacao