nixd/Parser: make parsing memory-safe for errors, using RAII #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclyc
force-pushed
the
nixd/parser/RAII
branch
2 times, most recently
from
a25e095
to
d496dd3
Compare
inclyc
commented
Jun 29, 2023
inclyc
force-pushed
the
tool/nixd-ast-dump
branch
from
8d2e954
to
46c3ee6
Compare
Free memory using a series of context object, record all allocated references, and free them automatically. Previous implementation do require there are no syntax errors. But this one is not leaking for any errors.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free memory using a series of context object, record all allocated references, and free them automatically.
Previous implementation do require there are no syntax errors. But this one is not leaking for any errors.