New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixd/fork: forking concurrency #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclyc
commented
Jun 2, 2023
inclyc
commented
Jun 3, 2023
inclyc
commented
Jun 3, 2023
Now all features are implemented in forking architecture, however looks like something is not working in github ci, but I cannot reproduce locally. |
inclyc
commented
Jun 3, 2023
junaire
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to eval workspace files in a separated process. When we update the workspace, we call
fork()
to lazily duplicate nixd itself. And, the server turns itself intoWorker
mode, which means:Hover
The main process it self redirects LSP requests to versioned workers, and just choose the best result, and thus should be cancellable.
The workers are managed in a deque, which means we can kill outdated processes (and thus free the memory).
regression status: