Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom prefixes #97

Merged
merged 1 commit into from Dec 13, 2023
Merged

Conversation

Janik-Haag
Copy link
Member

@Janik-Haag Janik-Haag commented Dec 7, 2023

This adds the ability to define a custom prefix like lib or utils which is currently hardcoded.
Sadly this will be probably be a breaking change since I didn't see a way to set default values for arguments
The only thing missing from this PR I can think of would be a CHANGELOG.md entry.

@Janik-Haag
Copy link
Member Author

cc @infinisil

src/main.rs Outdated Show resolved Hide resolved
@infinisil
Copy link
Collaborator

Looking good!

The only thing missing from this PR I can think of would be a CHANGELOG.md entry.

That's one thing I'd also like to have, ideally as descriptive as possible :D

Copy link
Collaborator

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed to update the change log a bit, looking good now!

@infinisil infinisil merged commit 2def30e into nix-community:master Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants