Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmdline arguments to the kernel parameters #7

Closed
wants to merge 1 commit into from

Conversation

andir
Copy link

@andir andir commented Jan 10, 2022

This allows users to add additional kernel arguments via the Utilities
-> Kernel parameters menu entry in netboot.xyz. For systems that rely on
serial consoles this is critical as otherwise the booted system will
never be visible on the serial console.

This allows users to add additional kernel arguments via the Utilities
-> Kernel parameters menu entry in netboot.xyz. For systems that rely on
serial consoles this is critical as otherwise the booted system will
never be visible on the serial console.
@Mic92
Copy link
Member

Mic92 commented Jan 11, 2022

Also an attempt to do this in nixpkgs: NixOS/nixpkgs#150360

@Mic92
Copy link
Member

Mic92 commented Jan 11, 2022

We should coordinate efforts here and avoid adding kernel command-line twice. Maybe we can backport the patch in nixpkgs to 21.11?

@Mic92
Copy link
Member

Mic92 commented Jan 11, 2022

cc @Enzime

@Enzime
Copy link

Enzime commented Jan 11, 2022

I think the PR on the nixpkgs side is good to go, if you guys would like to review it.

I'm not sure if anything else is necessary, but I've added a backport-21.11 tag.

@Mic92
Copy link
Member

Mic92 commented Jan 19, 2022

I merged the nixpkgs one.

@Mic92 Mic92 closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants