-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect derivation file sometimes #24
Comments
Maybe we can filter the list coming from |
How about just taking the shortest matching name? |
The (notice the "legacy" and "outdated" labels) Maybe there is a way to only query the "outdated" ones from Repology API? Not too familiar with it. On the other hand, isl isn't as easy to fix given how the file is structured. The best solution right now might just be to blacklist them. We don't have too many 'multiple versions, single name' anyway. |
That won't work because the name of the attribute is still 'isl' and 'libgit2'. We query isl-0.15 and libgit2-0.25.1. The issue is that the "OLD_VERSION" is wrong that we're getting from Repology. |
Yes, I'm already doing that. Is there some bit of information we need that we don't get from this line?
|
It should be:
|
Oh sorry, I see now that there are multiple entries for nixpkgs unstable. Yes, I think I can fix my repology api code to handle that better. |
Yeah looking at the API, the "status" code returned should be "outdated" (as opposed to "legacy"). |
Fixed repology-api and checked the output matches what @matthewbauer said above. |
protects against problems caused by #24
I added a check for version compatibility. It should give up trying to update an attrpath that contains an incompatible version string now. |
This is probably the correct file, but it got to it the wrong way, so it has the wrong attrpath: NixOS/nixpkgs#40830 |
I'm closing this in favor of having specific issues about each problem related to this. |
Our new way of figuring out the derivation file is sometimes wrong. For example,
libgit2
picked the specific version instead of the non-specific one: "libgit2_0_25: 0.25.1 -> 0.26.3"NixOS/nixpkgs#37474
Same for
isl
"isl_0_15: 0.15 -> 0.19"NixOS/nixpkgs#37453
cc @matthewbauer
The text was updated successfully, but these errors were encountered: