Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSearch description #17

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Add OpenSearch description #17

merged 1 commit into from
Jan 25, 2023

Conversation

phaer
Copy link
Member

@phaer phaer commented Jan 25, 2023

This should allow users to add noogle search to their browser toolbar. See mdn or source of search.nixos.org.

I've noticed that noogle does not currently handle unquoted terms, i.e. https://noogle.dev?term=trace does not yield results, while https://noogle.dev/?term="trace" does. Hope i got the quoting right in xml - (i hadn't)

Thanks for your work on noogle, it's such a useful project 🎉

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
noogle ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 9:31PM (UTC)

@github-actions
Copy link
Contributor

Latest commit: 46a42aae55e93ec9a974fa6c2c7e6d1f019cfe1e
Preview URL: https://db0e5304.noogle.pages.dev
Branch Preview URL: https://pr-17.noogle.pages.dev

@github-actions
Copy link
Contributor

Latest commit: 710fd2c731e31d60b9b857bb2881fcd7cf48131e
Preview URL: https://ff005e4a.noogle.pages.dev
Branch Preview URL: https://pr-17.noogle.pages.dev

@github-actions
Copy link
Contributor

Latest commit: c1ad48270d856792b90fcf63b18e7487c9208d09
Preview URL: https://b2d17e33.noogle.pages.dev
Branch Preview URL: https://pr-17.noogle.pages.dev

This allows users to add noogle search to their browser toolbar. See https://developer.mozilla.org/en-US/docs/Web/OpenSearch#autodiscovery_of_search_plugins or search.nixos.org
@hsjobeki
Copy link
Collaborator

I am currently not familiar with how that integration works. Thanks for adding the feature.
Is the quotation causing problems with the integration?
its currently neccessary as all query params must be valid JSON (url encoded) otherwise they are ignored

@github-actions
Copy link
Contributor

Latest commit: 2eb5c7395dcf188f0346ee8a4cb1a83555ea011a
Preview URL: https://655d3e40.noogle.pages.dev
Branch Preview URL: https://pr-17.noogle.pages.dev

@hsjobeki
Copy link
Collaborator

Thanks for your help @phaer
Seems to work, just tested it locally. Somehow the openSearch does not work on the preview deployment.
I'll merge it.

@hsjobeki hsjobeki merged commit a7ded12 into nix-community:main Jan 25, 2023
@phaer
Copy link
Member Author

phaer commented Jan 25, 2023

Worked for me on https://noogle-git-fork-phaer-main-hsjobeki.vercel.app/ but not on the *.pages.dev subdomains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants