Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

fix completion for empty prefix #104

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -423,15 +423,43 @@ impl App {
let (ast, content, _) = self.files.get(&params.text_document.uri)?;
let offset = utils::lookup_pos(content, params.position)?;

// complete after "pkgs." -> name is empty
let node = ast.node();
// TODO rename name to prefix
let (node, scope, name) =
self.scope_for_ident(params.text_document.uri.clone(), &node, offset)?;

if name == "" {
//eprintln!("prefix is empty. suggesting all variables in scope");
let mut completions = Vec::new();
for (var, data) in scope {
let det = data.render_detail();
completions.push(CompletionItem {
label: var.clone(),
documentation: data
.documentation
.map(|x| lsp_types::Documentation::String(x)),
deprecated: Some(data.deprecated),
text_edit: Some(CompletionTextEdit::Edit(TextEdit {
range: Range {
start: params.position,
end: params.position,
},
new_text: var.clone(),
})),
detail: Some(det),
..CompletionItem::default()
});
}
return Some(completions);
}

// Re-open, because scope_for_ident may mutably borrow
let (_, content, _) = self.files.get(&params.text_document.uri)?;

let mut completions = Vec::new();
for (var, data) in scope {
//eprintln!("prefix={} var={}", name, var);
if var.starts_with(&name.as_str()) {
let det = data.render_detail();
completions.push(CompletionItem {
Expand Down