lineageos: Lineage 20.0 support #213

Atemu · 2023-09-13T13:56:50Z

No description provided.

samueldr · 2023-09-14T00:08:10Z

Can the removal of 17.1/18.1 be done in another PR?

I know you haven't tested them, and don't intend to support them, but that change to me is surprising when seeing "Lineage 20.0 support" as the PR name.

It's fine if you don't update their device dirs either in this PR.

It would also make visually reviewing some of the changes in lineageos/default.nix easier, since git is eager to assume some unrelated (I think) changes are related.

(I'll also add that selfishly it will make it easier for me to re-integrate the changes for 18.1 and my device if the change is less intertwined with this PR...)

mannp · 2023-09-14T08:12:00Z

(I'll also add that selfishly it will make it easier for me to re-integrate the changes for 18.1 and my device if the change is less intertwined with this PR...)

Not all of my devices work with Lineage20 either :-/

Atemu · 2023-09-14T08:38:50Z

I'm personally fine with keeping the old 17.1 and 18 states around but I'll add a note that they're unmaintained.

Atemu · 2023-09-14T09:04:02Z

Another thing is that I may have accidentally broken many devices due to the update script being a bit broken. I'll do one last update of los 17.1 and 18.1 after the fixes.

/tmp is usually a tmpfs and some vendor dirs require >16GB of space. That blows up even on setups with 32GB of RAM with default tmpfs size (50%).

Prints device data and URLs to be fetched

Don't ask me why their branches are named 20 rather than 20.0

(separate commit for keeping the first one small)

Included in metadata now

This fixes a really nasty bug where the updater would skip fetching a rev because it's already the newest, not have it in the store and therefore erroneously conclude that it doesn't have linage.dependencies.

Atemu · 2023-09-14T11:30:30Z

Updating them is (perhaps unsurprisingly) broken. I'm just not going to bother. 17.1 and 18.1 are now untouched.

samueldr · 2023-09-14T21:58:45Z

Thank you, I might not have been 100% precise, it's fine if it's broken, I mainly want to (selfishly) have a way forward, and absolutely do not want you to lose time supporting them since in the current state it was already not great anyway.

flavors/lineageos/default.nix

Also refactored this bit to be quite a bit nicer to read

I had assumed I needed this but it's easier to just implement this pattern in Nix.

This makes LOS updates reproducible given a full mirror state!

Atemu · 2023-10-12T21:09:41Z

Alright, after some cleanup LOS 19.1 evals again and I can run reproducibly the updater to confirm my cleanup still works, hooray!

I'll now try building LOS 19.1 and then running it on my broken cheeseburger to see whether everything still works. If it does, I think we're close to merging this.

I'd love some review, specifically on the python parts. I still have very little experience in python.

Atemu · 2023-10-13T10:36:34Z

Alright, LOS 19.1 seems to be working just fine now. If nobody objects the next few days, I'll merge.

Atemu · 2023-10-23T13:05:38Z

LOS 19.1 can't be updated anymore because there are now devices which only support LOS 20. I'm inclined to put LOS 19.1 into the unmaintained bucket with 17.1 and 18.1 because I can't be bothered to fix that.

Atemu · 2023-10-28T18:28:39Z

There you go. If anyone finds a breakage in the other flavours, let me know. I'll either try to fix them or drop the other flavours aswell.

minijackson · 2023-10-28T20:04:50Z

Hey there, thank you so much for this PR!

I've tried building the FP3 LineageOS otaDir from robotnix master, but the robotnix-lineage_FP3-2023100409 build failed with:

FAILED:
hardware/qcom-caf/wlan/wcnss-service/Android.mk: error: "wcnss_service (EXECUTABLES android-arm64) missing libqmi_common_so (SHARED_LIBRARIES android-arm64)"
You can set ALLOW_MISSING_DEPENDENCIES=true in your environment if this is intentional, but that may defer real problems until later in the build.
build/make/core/main.mk:1130: error: exiting from previous errors.

I'm an Android noob, so I'm not sure what's going on.

Atemu · 2023-10-29T05:01:44Z

Indeed, I can reproduce. Looks like that was an upstream issue though because it builds with a newer LOS.

Atemu@10edcae

Atemu requested review from RaitoBezarius and danielfullmer September 13, 2023 13:56

Atemu force-pushed the lineage-20.0 branch from b2f677d to dd5d215 Compare September 14, 2023 08:53

Atemu requested a review from samueldr September 14, 2023 08:54

Atemu force-pushed the lineage-20.0 branch from dd5d215 to 438f395 Compare September 14, 2023 08:58

Atemu added 21 commits September 14, 2023 13:26

lineageos: 2022041111 -> 2022052416

bf57db8

lineageos-19.1: 2022052416 -> 2022100915

94dd70c

12: drop merged patch in lineageos

beb61d8

lineageos: 2022100915 -> 2022100921

eb8e67e

lineageos: use /var/tmp as TMPDIR

5263414

/tmp is usually a tmpfs and some vendor dirs require >16GB of space. That blows up even on setups with 32GB of RAM with default tmpfs size (50%).

lineageos: 2022100921 -> 2022101611

f142d5c

lineageos: update buildDateTime automatically when running update.sh

d259c7d

lineageos: add workaround for deadpool and wade

1c4d075

lineageos: 2022101611 -> 2022110516

54f60cf

lineageos: 2022101611 -> 2022123019

ba061f8

lineageos/update_device_dirs: add debug arg

14684e5

Prints device data and URLs to be fetched

lineageos/update_device_dirs: handle lineage-20.0

71e5a8e

Don't ask me why their branches are named 20 rather than 20.0

lineageos: add workaround for 10.or G

c64f6cf

lineageos: update_device_dirs: refactor and more workarounds

718dfb3

lineageos: handle NIX_REMOTE

528f857

lineageos: add more device_dirs workarounds

aa0df00

lineageos: support LineageOS 20

11e02c0

lineageos-20: init at 2023032812

6e78fa6

(separate commit for keeping the first one small)

lineageos: drop bacon workaround

b997bc3

Included in metadata now

microg: update patch for Android 13

60c5b51

lineageos: update workarounds

e24eb4c

Atemu added 4 commits September 14, 2023 13:27

lineageos: patch around upstream trying to run repo during build

e1b99ec

lineageos: update_device_dirs: don't clear deps when skipped

c0131d8

This fixes a really nasty bug where the updater would skip fetching a rev because it's already the newest, not have it in the store and therefore erroneously conclude that it doesn't have linage.dependencies.

lineageos: fix broken deps

8b552cf

lineageos: mark 17.1 and 18.1 as unmaintained

247e1e5

Atemu force-pushed the lineage-20.0 branch from 438f395 to 247e1e5 Compare September 14, 2023 11:29

lineageos: update vendor -commmon workarounds

23aed90

Atemu added 5 commits September 30, 2023 12:28

lineageos: add mechanism to ignore devices we can't support

45b36bc

lineageos: ignore nx651

373151f

lineageos: 2023091019

7fdb8d2

lineageos-20: 2023093009

692ed26

lineageos-20: 2023100409

f912e3b

Atemu mentioned this pull request Oct 12, 2023

lineageos: 2022041111 -> 2022110516 #190

Closed

Atemu commented Oct 12, 2023

View reviewed changes

flavors/lineageos/default.nix Outdated Show resolved Hide resolved

Atemu added 4 commits October 12, 2023 22:28

lineageos: fix eval on lineageos-19.1

dc85bb3

Also refactored this bit to be quite a bit nicer to read

lineageos: drop vendor_dir metadata again

4643e89

I had assumed I needed this but it's easier to just implement this pattern in Nix.

lineageos: use hudson metadata from ROBOTNIX_GIT_MIRRORS

a4ca957

This makes LOS updates reproducible given a full mirror state!

lineageos: re-generate device-metadata

b2bdd1e

Atemu added 2 commits October 23, 2023 15:07

lineageos: updated ignores/excludes

0584724

lineageos: mark 19.1 as unmaintained

854616e

Atemu merged commit 73d6b0b into nix-community:master Oct 28, 2023

Atemu deleted the lineage-20.0 branch October 28, 2023 18:27

Atemu mentioned this pull request May 23, 2024

LineageOS 21 and detailed instructions on adding a flavor #235

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lineageos: Lineage 20.0 support #213

lineageos: Lineage 20.0 support #213

Atemu commented Sep 13, 2023

samueldr commented Sep 14, 2023 •

edited

Loading

mannp commented Sep 14, 2023 •

edited

Loading

Atemu commented Sep 14, 2023

Atemu commented Sep 14, 2023 •

edited

Loading

Atemu commented Sep 14, 2023

samueldr commented Sep 14, 2023

Atemu commented Oct 12, 2023

Atemu commented Oct 13, 2023

Atemu commented Oct 23, 2023

Atemu commented Oct 28, 2023

minijackson commented Oct 28, 2023

Atemu commented Oct 29, 2023

lineageos: Lineage 20.0 support #213

lineageos: Lineage 20.0 support #213

Conversation

Atemu commented Sep 13, 2023

samueldr commented Sep 14, 2023 • edited Loading

mannp commented Sep 14, 2023 • edited Loading

Atemu commented Sep 14, 2023

Atemu commented Sep 14, 2023 • edited Loading

Atemu commented Sep 14, 2023

samueldr commented Sep 14, 2023

Atemu commented Oct 12, 2023

Atemu commented Oct 13, 2023

Atemu commented Oct 23, 2023

Atemu commented Oct 28, 2023

minijackson commented Oct 28, 2023

Atemu commented Oct 29, 2023

samueldr commented Sep 14, 2023 •

edited

Loading

mannp commented Sep 14, 2023 •

edited

Loading

Atemu commented Sep 14, 2023 •

edited

Loading