Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on target #25

Merged
merged 6 commits into from Mar 4, 2020
Merged

Build on target #25

merged 6 commits into from Mar 4, 2020

Conversation

roberth
Copy link
Contributor

@roberth roberth commented Mar 4, 2020

Allows non-cross deployment across platforms by building on the target machine.

zimbatm
zimbatm reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on principle with a few comments

deploy_nixos/main.tf Outdated Show resolved Hide resolved
deploy_nixos/main.tf Outdated Show resolved Hide resolved
deploy_nixos/nixos-deploy.sh Outdated Show resolved Hide resolved
deploy_nixos/nixos-deploy.sh Show resolved Hide resolved
@roberth roberth requested a review from zimbatm March 4, 2020 18:51
zimbatm
zimbatm reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment I missed from my original review and it's good to go

deploy_nixos/nixos-deploy.sh Outdated Show resolved Hide resolved
deploy_nixos/nixos-deploy.sh Show resolved Hide resolved
@roberth roberth requested a review from zimbatm March 4, 2020 21:21
@zimbatm zimbatm merged commit 2ec46ce into nix-community:master Mar 4, 2020
@zimbatm
Copy link
Member

zimbatm commented Mar 4, 2020

thanks!

@roberth roberth mentioned this pull request Mar 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @zimbatm