Scan only runtime dependencies #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dermetfan
commented
Sep 17, 2021
|
Store paths that appear in the closure but are also |
Derivation input sources have no deriver and can safely be skipped. Also fix comment that says the `deriver` field was added to `nix path-info` in Nix 2.4. That is incorrect, it is already present in stable Nix.
|
Turns out the |
dermetfan
added a commit
to input-output-hk/bitte
that referenced
this pull request
Sep 24, 2021
…cies use forked vulnix until nix-community/vulnix#80 is merged
dermetfan
added a commit
to input-output-hk/bitte
that referenced
this pull request
Sep 24, 2021
…cies use forked vulnix until nix-community/vulnix#80 is merged
|
@ckauhaus could we get this merged? |
13 tasks
|
Given the context, I assume that @ckauhaus is no longer active. If anybody is interested, I opened a new issue to nominate yourself as a maintainer. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--closureflag that scans the closure of an output path.Currently vulnix scans all dependencies (unless
--no-requisitesis given) so buildtime-only dependencies are included. Depending on the threat model it may be desirable to scan only runtime dependencies to avoid writing a huge whitelist.Nix has a
deriverfield in the JSON output ofnix path-infothat I hoped we could use. Unfortunately we run into the same problem as #69 so we still have to shell out to Nix every time that path does not exist.