This repository has been archived by the owner on May 20, 2021. It is now read-only.
Support git dependencies #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moretea @lheckemann hi, could you please review this pr (soon will fix tests by using new node version , but they are working locally) |
|
TODO:
|
zimbatm
reviewed
Jan 11, 2019
srghma
commented
Jan 11, 2019
Having:
mkYarnPackage {
name = "this-package";
src = ./. # directory with files ./file1, ./file2, ./package.json
workspaceDependencies = [other-package] # other-package contains
./otherfile1, ./otherfile2, ./package.json
}
Before:
`tree` during preInstall shows following directory structure
./node_modules
./.yarnrc
./file1
./file2
./deps/this-package/file1
./deps/this-package/file2
./deps/this-package/package.json
./deps/other-package/otherfile1
./deps/other-package/otherfile2
./deps/other-package/package.json
After
`tree` during preInstall shows following directory structure
./node_modules
./.yarnrc
./deps/this-package/file1
./deps/this-package/file2
./deps/this-package/package.json
./deps/other-package/otherfile1
./deps/other-package/otherfile2
./deps/other-package/package.json
zimbatm
reviewed
Apr 5, 2019
default.nix
Outdated
| @@ -1,10 +1,14 @@ | |||
| { pkgs ? import <nixpkgs> {} | |||
| , nodejs ? pkgs.nodejs | |||
| , nodejs ? pkgs.nodejs-8_x | |||
There was a problem hiding this comment.
we should use the nixpkgs default version
Suggested change
| , nodejs ? pkgs.nodejs-8_x | |
| , nodejs ? pkgs.nodejs |
There was a problem hiding this comment.
this change makes ci tests fail
✘ ~/projects/yarn2nix pull85 export NIXPKGS_CHANNEL=nixos-18.03 && ./run-tests.sh
--- Running tests with IFD enabled
building '/nix/store/xvv3zdgw7h9q1ilikhph9wx3qhkg9kb8-fixup_yarn_lock.drv'...
installing
node -v
v6.14.4
patching script interpreter paths in /nix/store/1cga0h2vqbr7xxxvjn9ccvk4n8jzw0zp-fixup_yarn_lock
/nix/store/1cga0h2vqbr7xxxvjn9ccvk4n8jzw0zp-fixup_yarn_lock/bin/fixup_yarn_lock: interpreter directive changed from "/usr/bin/env node" to "/nix/store/85y6qr70pyv2njvg1pnsl4zcln540iyc-nodejs-6.14.4/bin/node"
building '/nix/store/x2qkrxrb97lmzzj2k840s4xnksbrsqax-yarn2nix-modules-1.0.0.drv'...
configuring
building
yarn config v1.5.1
success Set "yarn-offline-mirror" to "/nix/store/3xz5j2lp0y2cqcnhsinvhzgdcqqj5ncj-offline".
Done in 0.03s.
/nix/store/1cga0h2vqbr7xxxvjn9ccvk4n8jzw0zp-fixup_yarn_lock/bin/fixup_yarn_lock:46
)
^
SyntaxError: Unexpected token )
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:549:28)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.runMain (module.js:611:10)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:160:9)
builder for '/nix/store/x2qkrxrb97lmzzj2k840s4xnksbrsqax-yarn2nix-modules-1.0.0.drv' failed with exit code 1
I propose to remove tests for NIXPKGS_CHANNEL=nixos-18.03
There was a problem hiding this comment.
apart from that I would say the pr is ready to be consumed
|
@srghma is it ready? |
|
@zimbatm, didn't think anyone is interested because of lot of changes) Yes, I use it successfully in my company. Only one thing left: I want to share function urlToName between executables, will do it this weekend |
|
yes it's quite a bit of changes :) If you are confident that it works I am ready to merge it when you are. |
…ult nodejs is outdated (v6, but minimal is v8)
|
@zimbatm hi, can we merge now? |
|
@zimbatm tnx for merging it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr subsumes:
#85
#23
Closes:
Difference: