Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Implementation of ListOf #30

Closed
lapp0 opened this issue Jul 5, 2021 · 1 comment · Fixed by #157
Closed

Complete Implementation of ListOf #30

lapp0 opened this issue Jul 5, 2021 · 1 comment · Fixed by #157
Labels
good first issue Good for newcomers

Comments

@lapp0
Copy link
Collaborator

lapp0 commented Jul 5, 2021

ListOf field for types containing "list of" must be completed in widgets.py. It can behave similarly to AttributeSetOf.

@lapp0 lapp0 added this to the V0.1 milestone Jul 5, 2021
@lapp0 lapp0 mentioned this issue Jul 25, 2021
@lapp0 lapp0 added the good first issue Good for newcomers label Oct 13, 2021
@lapp0
Copy link
Collaborator Author

lapp0 commented Oct 27, 2021

Currently elements of a list aren't branches in option_tree.py. there needs to be a way to access, for example, access networking.firewall.allowedTCPPorts[1] so it can be used as a URI and enable ListOf navigation and 'editing of list elements.

There are two ways to fix this:

  • clean: have lib.nix retrieve the definition for list elements
  • dirty: have option tree iterate over option_definition.obj to get the expression string and object for each subelement.
  • less dirty, but suboptimal: retrieve elements in parser.py

Will try the clean solution first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant