Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Navigation Layout #80

Merged
merged 12 commits into from
Aug 9, 2021
Merged

Clean Navigation Layout #80

merged 12 commits into from
Aug 9, 2021

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Aug 3, 2021 •
edited
Loading

origin/master
image

origin/clean-navigation
image

fixes #31 (not really, it actually just deletes StringListField and assumes DynamicListOf[TextField] will handle it

@lapp0 lapp0 changed the base branch from master to expression-field August 3, 2021 08:05
@lapp0 lapp0 mentioned this pull request Aug 3, 2021
Closed
@adrianparvino
Copy link
Collaborator

adrianparvino commented Aug 8, 2021 •
edited
Loading

General look and feel comment for now: I think having 3-4 (maybe dependent on the window width or user-customizable?) lists makes sense. Or maybe even make it anchor around attrsOf or listOf? I'm for the navigation bar, but having only 2 columns feels too cramped.

@lapp0 lapp0 mentioned this pull request Aug 8, 2021
Closed
3 tasks
@lapp0
Copy link
Collaborator Author

lapp0 commented Aug 8, 2021

I disagree, but I could be wrong. We should leave this as a question for users who volunteer to UX test.

#87

adrianparvino
adrianparvino reviewed Aug 8, 2021
View reviewed changes
Copy link
Collaborator

@adrianparvino adrianparvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my technical review:

nixui/graphics/field_widgets.py Show resolved Hide resolved
nixui/graphics/navbar.py Show resolved Hide resolved
nixui/options/attribute.py Show resolved Hide resolved
@lapp0 lapp0 changed the base branch from expression-field to master August 9, 2021 00:05
@lapp0 lapp0 merged commit bcb31dc into master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianparvino adrianparvino adrianparvino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean Constant Width Navigation Implement insert_item AND current_value for StringListField
2 participants
@lapp0 @adrianparvino