Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example text extraction for tooltip #230

Merged
merged 1 commit into from Dec 6, 2021
Merged

Add example text extraction for tooltip #230

merged 1 commit into from Dec 6, 2021

Conversation

jeffa5
Copy link
Contributor

@jeffa5 jeffa5 commented Dec 5, 2021 •
edited

This defaults to using the example as is, unless it is of the
literalExample or literalExpression type.

Fixes #122

@lapp0
Copy link
Collaborator

lapp0 commented Dec 6, 2021 •
edited

Thanks for your PR!

All tests pass, reviewing code now.

lapp0
lapp0 requested changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@lapp0 lapp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good less one minor change request. Thanks!

nixui/graphics/richtext.py Outdated Show resolved Hide resolved
@jeffa5
Add example text extraction
b74d932 
This defaults to using the example as is, unless it is of the
literalExample or literalExpression type.
@lapp0 lapp0 merged commit b8fe71d into nix-gui:master Dec 6, 2021
@jeffa5 jeffa5 deleted the examples branch December 6, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lapp0 lapp0 lapp0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option "Example" in ToolTip
2 participants
@jeffa5 @lapp0