Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace void's Void with std Infallible #1238

Closed
tesuji opened this issue May 12, 2020 · 0 comments · Fixed by #1239
Closed

Replace void's Void with std Infallible #1238

tesuji opened this issue May 12, 2020 · 0 comments · Fixed by #1239

Comments

@tesuji
Copy link

tesuji commented May 12, 2020

No description provided.

oherrala added a commit to oherrala/nix that referenced this issue May 13, 2020
@oherrala
Replace void crate with Rust standard lib Infallible type
0c63648 
std::convert::Infallible has been available since Rust 1.34 and nix
currently targets Rust 1.36 or later so this should not cause
problems.

Fixes nix-rust#1238
@oherrala oherrala mentioned this issue May 13, 2020
Merged
oherrala added a commit to oherrala/nix that referenced this issue May 17, 2020
@oherrala
Replace void crate with Rust standard lib Infallible type
d7725bc 
std::convert::Infallible has been available since Rust 1.34 and nix
currently targets Rust 1.36 or later so this should not cause
problems.

Fixes nix-rust#1238
bors bot added a commit that referenced this issue May 17, 2020
@bors @oherrala
Merge #1239
d3fef37 
1239: Replace void crate with Rust standard lib Infallible type r=asomers a=oherrala

[`std::convert::Infallible`](https://doc.rust-lang.org/stable/std/convert/enum.Infallible.html) has been available since Rust 1.34 and nix currently targets Rust 1.36 or later so this should not cause problems.

Fixes #1238

Co-authored-by: Ossi Herrala <oherrala@iki.fi>
@bors bors bot closed this as completed in 71aa2a6 May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace void crate with Rust standard lib Infallible type oherrala/nix
1 participant
@tesuji