Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing EventFlag bitflags on OpenBSD (EV_DISPATCH, EV_RECEIPT) #1251

Closed
nickpelone opened this issue May 26, 2020 · 7 comments · Fixed by #1252
Closed

Missing EventFlag bitflags on OpenBSD (EV_DISPATCH, EV_RECEIPT) #1251

nickpelone opened this issue May 26, 2020 · 7 comments · Fixed by #1252

Comments

@nickpelone
Copy link
Contributor

Hey there!

OpenBSD has been excluded from EV_DISPATCH and EV_RECEIPT for a while now, but they have since landed in OpenBSD (A while ago, pretty sure.)

These being excluded on that platform prevent crates such as smol from building (related issue: smol-rs/smol#146)

Any way these can be added for target_os = "openbsd"?

Thanks for your time.
@asomers
Copy link
Member

asomers commented May 26, 2020

Sure, just submit a PR. Note that Nix doesn't build for OpenBSD in CI; so we rely on our users to catch even basic build problems.

@qbit
Copy link

qbit commented May 26, 2020

fwiw, sr.ht offers OpenBSD CI - there are even convenient dispatchers for building from Github commits!

@asomers
Copy link
Member

asomers commented May 26, 2020

Yes. However, sr.ht isn't free, and none of Nix's maintainers are OpenBSD users, so we haven't stumped up for it.

@nickpelone
Copy link
Contributor Author

I have opened #1252. Thanks!

@nickpelone nickpelone mentioned this issue May 26, 2020
Merged
@mahkoh
Copy link

mahkoh commented May 29, 2020

sr.ht is free. I'm using it for OpenBSD builds myself. After the alpha it will no longer be free but you can unlock all features for $2/month. It's also much faster than cirrus for FreeBSD builds.

@asomers
Copy link
Member

asomers commented May 29, 2020

My interpretation is that it's free for evaluation purposes, but you're kind of a jerk if you abuse the privilege. Am I wrong?

@mahkoh
Copy link

mahkoh commented May 29, 2020

I believe you are wrong.

bors bot added a commit that referenced this issue May 31, 2020
@bors @nickpelone
Merge #1252
a3ecdb1 
1252: Add EV_DISPATCH, EV_RECEIPT items for EventFlags, and fix build on OpenBSD r=asomers a=nickpelone

This pull request:

- Adds `EV_DISPATCH` and `EV_RECEIPT` to `EventFlags`. OpenBSD supports these now. 
c379d1a
- Fixes a regression that caused `nix` to be unable to build on OpenBSD since #1208. 
dd0a990
- Makes a change to avoid a deprecation warning from `libc` crate, which breaks tests. 
0f9fcbd

Since I know y'all don't have OpenBSD in CI right now, I've attached the results of a `cargo test` run on OpenBSD 6.7.

Thanks for your time!

[testresults.txt](https://github.com/nix-rust/nix/files/4684597/testresults.txt)

Fixes #1251 

Co-authored-by: Nick Pelone <nick.pelone@calyptix.com>
@bors bors bot closed this as completed in 84e66d7 May 31, 2020
@bors bors bot closed this as completed in #1252 May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add EV_DISPATCH, EV_RECEIPT items for EventFlags, and fix build on OpenBSD nickpelone/nix
4 participants
@qbit @asomers @mahkoh @nickpelone