Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timer_* bindings #1424

Closed
5 tasks
Zapeth opened this issue Apr 12, 2021 · 3 comments · Fixed by #1622
Closed
5 tasks

Add timer_* bindings #1424

Zapeth opened this issue Apr 12, 2021 · 3 comments · Fixed by #1622
Labels
E-good-first-bug

Comments

@Zapeth
Copy link

Zapeth commented Apr 12, 2021

Feature request for adding bindings for the following POSIX timer functions to the crate:

  • timer_create
  • timer_delete
  • timer_settime
  • timer_gettime
  • timer_getoverrun

See e.g. https://www.man7.org/linux/man-pages/man2/timer_create.2.html
@asomers
Copy link
Member

asomers commented May 30, 2021

That sounds like a good feature. Would you be willing to implement it?

@Zapeth
Copy link
Author

Zapeth commented Jun 1, 2021

I could try, but considering I only have rather limited experience with Rust I'm pretty sure other people that might be willing/interested to implement this feature would be better suited.

As a sidenote, I just checked if the libc crate provides these functions and it seems they have yet to be implemented as well (a PR draft exists but seems to be inactive for some time now), so that might be a necessary first step anyway before starting to work on it here.

@blt
Copy link
Contributor

blt commented Dec 17, 2021 •
edited

While it does appear that libc now has the relevant timer_* functions I think rust-lang/libc#2576 is a potential blocker. For what it's worth @asomers I need the timer functions and would be willing to provide an implementation. I'll put a PR together and get as far as possible with it.

blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
d13d147 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into
the project organization but hopefully this commit isn't too far off.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
@blt blt mentioned this issue Dec 28, 2021
Merged
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
accb88d 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into
the project organization but hopefully this patch isn't too far off.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
1b3a899 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into
the project organization but hopefully this patch isn't too far off.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
6edeef3 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into
the project organization but hopefully this patch isn't too far off.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
7f9da7d 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into
the project organization but hopefully this patch isn't too far off.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
956a733 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into
the project organization but hopefully this patch isn't too far off.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
28004aa 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into
the project organization but hopefully this patch isn't too far off.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
c557721 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 28, 2021
@blt
Introduce timer_* support
b55d254 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 29, 2021
@blt
Introduce timer_* support
36ff2c0 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 30, 2021
@blt
Introduce timer_* support
d7a9e5d 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 30, 2021
@blt
Introduce timer_* support
d0fa578 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit to blt/nix that referenced this issue Dec 30, 2021
@blt
Introduce timer_* support
e28c074 
This commit adds support for the signal timer mechanism in POSIX, the
mirror to timerfd on Linux.

Resolves nix-rust#1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
bors bot added a commit that referenced this issue Dec 31, 2021
@bors @blt @rtzoeller
Merge #1622 #1623
ee0543f 
1622: Introduce `timer_*` support  r=asomers a=blt

This commit adds support for the signal timer mechanism in POSIX, the mirror to timerfd on Linux. I wasn't _quite_ sure of how to fit into the project organization but hopefully this patch isn't too far off.

Resolves #1424

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

1623: Remove cc dependency on DragonFly r=asomers a=rtzoeller

f5ee22d removed the need for this dependency.

Co-authored-by: Brian L. Troutwine <brian@troutwine.us>
Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@bors bors bot closed this as completed in 77febe0 Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-good-first-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce timer_* support blt/nix
3 participants
@blt @asomers @Zapeth