Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the Minver CI check actually working? #1809

Closed
rtzoeller opened this issue Aug 26, 2022 · 1 comment
Closed

Is the Minver CI check actually working? #1809

rtzoeller opened this issue Aug 26, 2022 · 1 comment

Comments

@rtzoeller
Copy link
Collaborator

I noticed that Cargo.lock.msrv is currently listing an old version of libc which we can't possibly build with anymore (due to requiring new functions/constants)... it seems like the Minver CI check is not working correctly.

Do we need --locked? I'm guessing we're copying Cargo.lock.msrv to Cargo.lock and then promptly overwriting it with cargo check.

Or am I misunderstanding how this is intended to work?
@asomers
Copy link
Member

asomers commented Aug 26, 2022

The Cargo.lock.msrv file is used to test the MSRV, not for Minver. It is working, although I think we can eliminate it now that our MSRV is 1.56.1 too. Minver is tested separately, using the nightly compiler.

asomers added a commit to asomers/nix that referenced this issue Aug 26, 2022
@asomers
Eliminate Cargo.lock.msrv
29f4d52 
We no longer need it since updating our MSRV to 1.56.1.

Issue nix-rust#1809
@asomers asomers mentioned this issue Aug 26, 2022
Merged
bors bot added a commit that referenced this issue Aug 26, 2022
@bors @asomers
Merge #1810
1eb589f 
1810: Eliminate Cargo.lock.msrv r=rtzoeller a=asomers

We no longer need it since updating our MSRV to 1.56.1.

Issue #1809

Co-authored-by: Alan Somers <asomers@gmail.com>
@asomers asomers closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asomers @rtzoeller