Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream and use socket constants from libc #637

Closed
Susurrus opened this issue Jun 29, 2017 · 0 comments
Closed

Upstream and use socket constants from libc #637

Susurrus opened this issue Jun 29, 2017 · 0 comments

Comments

@Susurrus
Copy link
Contributor

Currently src/sys/socket/consts.rs relies on many hard-coded constants. I've recently gone and updated many of these in #636, but there's more work to do here:

  • Get all constants that are still numbers upstreamed in libc for all supported nix platforms
  • Adapt src/sys/socket/consts.rs to use libc values
  • Refactor the constant declarations such that all constants are only declared once with a #[cfg] that only enables the constant on the correct platforms.

To determine what constants are available on what platforms, you can search through the source (see here for a list of sources of various platforms).

This was referenced Jul 5, 2017
bors bot added a commit that referenced this issue Aug 1, 2017
647: merge socket constants r=Susurrus

> Refactor the constant declarations such that all constants are only declared once with a #[cfg] that only enables the constant on the correct platforms.

Closes #637 

(same PR as #646 but from another branch, to see if buildbot has a problem with PR made from master branch)
@bors bors bot closed this as completed in #647 Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant