Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot screws up pull requests from a "master" branch #652

Closed
asomers opened this issue Jul 7, 2017 · 2 comments
Closed

buildbot screws up pull requests from a "master" branch #652

asomers opened this issue Jul 7, 2017 · 2 comments
Assignees
@asomers

Comments

@asomers
Copy link
Member

asomers commented Jul 7, 2017

Buildbot is mostly building stuff fine. But if the source branch of a pull request is named "master", then buildbot will try to build the master branch of the nix repo instead of the source repo. But it can't find the revision in question, so the build fails. For example, PR #651, from mmstick/nix:master, led to this broken build: https://alan.ci/buildbot/#/builders/5/builds/229 .
@asomers asomers self-assigned this Jul 7, 2017
This was referenced Jul 7, 2017
Closed
Merged
@Susurrus
Copy link
Contributor

Susurrus commented Jul 7, 2017

Is this fixed or is there something more to do here?

@asomers
Copy link
Member Author

asomers commented Jul 7, 2017

My buildbot config change seems to have fixed it.

@asomers asomers closed this as completed Jul 7, 2017
@asomers asomers mentioned this issue Jul 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asomers asomers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asomers @Susurrus