Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm/musl, mips64, and s390x linux targets to Tier3 #657

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Jul 7, 2017

I don't know why these weren't added originally. They should work with cross.

@asomers
Copy link
Member

asomers commented Jul 8, 2017

LGTM

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2017
657: Add arm/musl, mips64, and s390x linux targets to Tier3 r=asomers

I don't know why these weren't added originally. They should work with `cross`.
@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 8, 2017

bors r-

@bors
Copy link
Contributor

bors bot commented Jul 8, 2017

Canceled

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 8, 2017

I don't know if the just released version of libc will work, since I saw a commit that inspired me to do this. Let's merge that first and then we can see if this works.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 8, 2017

Nvm, this doesn't actually make them blocking, so we can merge this.

Bors r+

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 8, 2017

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2017
657: Add arm/musl, mips64, and s390x linux targets to Tier3 r=Susurrus

I don't know why these weren't added originally. They should work with `cross`.
@bors
Copy link
Contributor

bors bot commented Jul 8, 2017

Build failed

@asomers
Copy link
Member

asomers commented Jul 8, 2017

On the rust=beta channel, test_wait hung. I've seen this on the bench for multithreaded tests, but not for single threaded tests. I'm going to try again.

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2017
657: Add arm/musl, mips64, and s390x linux targets to Tier3 r=asomers

I don't know why these weren't added originally. They should work with `cross`.
@notriddle
Copy link
Contributor

BuildBot is being unresponsive again...

@bors
Copy link
Contributor

bors bot commented Jul 8, 2017

Build failed

@asomers
Copy link
Member

asomers commented Jul 8, 2017

I think that Bors sometimes renames staging.tmp to staging instead of doing a merge commit, and BuildBot doesn't know to build the branch rename. I've just configured buildbot to build the staging.tmp branch as well, even though the Bors docs advise against it. We'll see if it starts picking up this change.

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2017
657: Add arm/musl, mips64, and s390x linux targets to Tier3 r=asomers

I don't know why these weren't added originally. They should work with `cross`.
@notriddle
Copy link
Contributor

Nope.

@asomers
Copy link
Member

asomers commented Jul 8, 2017

Ok, I figured it out. It's a matter of whether the repository ends in .git. When GitHub sends change requests, it leaves off that part. I introduced this error as part of my fix for issue #652 .

bors r-

@bors
Copy link
Contributor

bors bot commented Jul 8, 2017

Canceled

@asomers
Copy link
Member

asomers commented Jul 8, 2017

Try again.

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2017
657: Add arm/musl, mips64, and s390x linux targets to Tier3 r=asomers

I don't know why these weren't added originally. They should work with `cross`.
@bors
Copy link
Contributor

bors bot commented Jul 8, 2017

@bors bors bot merged commit 2153527 into nix-rust:master Jul 8, 2017
@notriddle
Copy link
Contributor

By the way, there's really no reason to build staging.tmp. Bors never just moves the commit from staging.tmp to staging; it always uses the Git Data API to take the staging.tmp commit and make one in staging with the same contents but a different commit message.

@Susurrus Susurrus deleted the more_targets branch July 9, 2017 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants