Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support preadv/pwritev on more platforms #690

Closed
asomers opened this issue Jul 19, 2017 · 3 comments
Closed

Support preadv/pwritev on more platforms #690

asomers opened this issue Jul 19, 2017 · 3 comments
Labels
A-features E-good-first-bug

Comments

@asomers
Copy link
Member

asomers commented Jul 19, 2017

As of rust-lang/libc@3e5b074 , libc defines preadv and pwritev for all of the BSDs as well as Linux. Rust should enable it for them in the post-0.9.0 release.
@morrowa morrowa mentioned this issue Apr 13, 2018
Merged
@morrowa
Copy link
Contributor

morrowa commented Apr 13, 2018

I've taken the liberty of submitting a PR for this issue as #883.

Please review it carefully as I didn't have a BSD handy upon which to test!

bors bot added a commit that referenced this issue Apr 18, 2018
@bors @morrowa
Merge #883
84ef78f 
883: Expose `preadv` and `pwritev` on BSDs r=Susurrus a=morrowa

This addresses issue #690.

It exposes the `preadv` and `pwritev` functions on supported BSDs (not including Apple platforms).

Co-authored-by: Andrew Morrow <andrew.d.morrow@gmail.com>
bors bot added a commit that referenced this issue Apr 19, 2018
@bors @morrowa
Merge #883
305141c 
883: Expose `preadv` and `pwritev` on BSDs r=asomers a=morrowa

This addresses issue #690.

It exposes the `preadv` and `pwritev` functions on supported BSDs (not including Apple platforms).

Co-authored-by: Andrew Morrow <andrew.d.morrow@gmail.com>
@mcginty
Copy link
Contributor

mcginty commented Apr 22, 2018

Should this be closed now that the PR is merged?

@asomers
Copy link
Member Author

asomers commented Apr 22, 2018

Yep.

@asomers asomers closed this as completed Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-features E-good-first-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asomers @Susurrus @mcginty @morrowa