Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement mknodat #1131

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

implement mknodat #1131

wants to merge 7 commits into from

Conversation

zmlcc
Copy link
Contributor

@zmlcc zmlcc commented Sep 29, 2019

This adds the mknodat function, which is part of POSIX https://pubs.opengroup.org/onlinepubs/9699919799/functions/mknod.html

mknodat seems not implemented in OSX, so I add conditional compilation attributes to exclude ios and macos

I don't find any test code about mknod, So tests of mknodat are not added either

This was referenced Sep 29, 2019
@asomers
Copy link
Member

asomers commented Oct 7, 2019

Yes, mknod may not have any test code, and that's a shame. You should still add tests for mknodat, and while you're at it it would be great to add them for mknod as well.

@zmlcc
Copy link
Contributor Author

zmlcc commented Oct 11, 2019

mknod test failed in many arch/os. Is mknod not widely implemented in different systems ?

@asomers
Copy link
Member

asomers commented Oct 12, 2019

The tests are probably failing due to permissions errors. Creating a device node requires root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants