Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement faccessat #1134

Closed
wants to merge 5 commits into from
Closed

Implement faccessat #1134

wants to merge 5 commits into from

Conversation

zmlcc
Copy link
Contributor

@zmlcc zmlcc commented Sep 30, 2019

This adds the faccessat function, which is part of POSIX https://pubs.opengroup.org/onlinepubs/9699919799/functions/faccessat.html

test cases are copied from access function

@zmlcc zmlcc mentioned this pull request Sep 30, 2019
@zmlcc
Copy link
Contributor Author

zmlcc commented Oct 1, 2019

I see test_drop failed in travis-ci log, but I should not change any code about drop.
What's the problem? Maybe try another round of ci test ?

@zmlcc zmlcc mentioned this pull request Oct 1, 2019
14 tasks
let tempdir = tempfile::tempdir().unwrap();
let path = tempdir.path().join("does_exist.txt");
let _file = File::create(path.clone()).unwrap();
assert_eq!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using assert_eq!(..., true), just use assert!(...).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@zmlcc
Copy link
Contributor Author

zmlcc commented Oct 10, 2019

Still test_drop failed in travis-ci log, why ?

@asomers
Copy link
Member

asomers commented Oct 12, 2019

I think the test_aio_drop failures are due to a bug in glibc. The PR looks good now. All that's needed is for you to squash your commits, and perhaps rebase to master.

@gliderkite
Copy link
Contributor

gliderkite commented Nov 19, 2020

Is there any update on this @zmlcc? I was looking for the same feature in nix Thanks

@nateavers nateavers mentioned this pull request Aug 5, 2022
@asomers
Copy link
Member

asomers commented Aug 6, 2022

superseded by #1780 .

@asomers asomers closed this Aug 6, 2022
bors bot added a commit that referenced this pull request Aug 6, 2022
1780: Implement faccessat r=asomers a=nateavers

This is a re-post of #1134, which seems to have been abandoned. Includes the changes requested in [this comment](#1134 (comment)).

Co-authored-by: Zhang Miaolei <zmlcc@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants