Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mkdtemp #1297

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add mkdtemp #1297

merged 1 commit into from
Dec 18, 2023

Conversation

DBLouis
Copy link
Contributor

@DBLouis DBLouis commented Sep 17, 2020

No description provided.

asomers
asomers requested changes Sep 19, 2020
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a CHANGELOG entry

src/unistd.rs Outdated Show resolved Hide resolved
src/unistd.rs Outdated Show resolved Hide resolved
src/unistd.rs Outdated Show resolved Hide resolved
@asomers
Copy link
Member

asomers commented Oct 3, 2020

Still needs a CHANGELOG entry.

@DBLouis DBLouis force-pushed the master branch 2 times, most recently from 9009f38 to 8a3a875 Compare August 10, 2021 18:15
@SteveLauC
Copy link
Member

Gentle ping on the author @DBLouis, I am sorry about the late response, would you like to finish this PR, just need to rebase your branch, discard the changes made to the CHANGELOG.md file and add a new file under the changelog directory, then we can merge it:)

file name would be 1297.added.md

 Added `mkdtemp` wrapper

SteveLauC
SteveLauC approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC added this pull request to the merge queue Dec 18, 2023
Merged via the queue into nix-rust:master with commit 172ca24 Dec 18, 2023
35 checks passed
@bjackman
Copy link

bjackman commented Feb 4, 2024

I noticed that the new mkdtemp is behind the feature feature. Is that indended? That feature already existed so seems like it may have been deliberate, but I also can't see what it's intended to mean.

I'm a rust noob, in case that helps contextualise the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers requested changes

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DBLouis @asomers @SteveLauC @bjackman