InetAddr::from_std should set sin_len/sin6_len on the BSDs #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
approved these changes
Jan 23, 2022
rtzoeller
commented
Jan 23, 2022
| @@ -330,6 +330,11 @@ impl InetAddr { | |||
| match *std { | |||
| net::SocketAddr::V4(ref addr) => { | |||
| InetAddr::V4(libc::sockaddr_in { | |||
| #[cfg(any(target_os = "dragonfly", target_os = "freebsd", | |||
| target_os = "haiku", target_os = "hermit", | |||
There was a problem hiding this comment.
I pulled the list of platforms which define these from rust-lang/libc. Although nix doesn't support Haiku or Hermit, there are other cfg blocks which reference them in nix, so I included them here.
I omitted newlib and VxWorks, as nix doesn't currently have any cfg blocks for them.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1246.