Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add XFS_SUPER_NUMBER to nix::sys::statfs #1743

Merged
merged 1 commit into from Oct 13, 2022
Merged

add XFS_SUPER_NUMBER to nix::sys::statfs #1743

merged 1 commit into from Oct 13, 2022

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Jun 10, 2022

Close #1742 .

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Jun 10, 2022

Seems xfs is not supported by linux musl and android. I'll fix it.

@asomers
Copy link
Member

asomers commented Jun 11, 2022

Looks like you may need to submit a PR to rust-lang/libc first.

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Jun 11, 2022

Looks like you may need to submit a PR to rust-lang/libc first.

I'm not sure if XFS actually supports these targets. I will check it first.

@SteveLauC
Copy link
Member

SteveLauC commented Oct 5, 2022 •
edited

Looks like you may need to submit a PR to rust-lang/libc first.

I'm not sure if XFS actually supports these targets. I will check it first.

Seems that musl does not support this, Androiddoes have it but it is missing from libc

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 8, 2022

Seems that musl does not support this, Androiddoes have it but it is missing from libc

Thanks for the information. I've forgotten this PR for a long time. I checked musl-libc and bionic-libc today and sent an issue to rust libc. See rust-lang/libc#2948 .

@MrCroxx MrCroxx mentioned this pull request Oct 9, 2022
Merged
bors added a commit to rust-lang/libc that referenced this pull request Oct 10, 2022
@bors
Auto merge of #2951 - MrCroxx:xx/bump-to-135, r=JohnTitor
56c9bba 
Bump to 0.2.135

I'm going to make a new release as requested by nix-rust/nix#1743 (comment) .
bors added a commit to rust-lang/libc that referenced this pull request Oct 10, 2022
@bors
Auto merge of #2951 - MrCroxx:xx/bump-to-135, r=JohnTitor
5ea58fe 
Bump to 0.2.135

I'm going to make a new release as requested by nix-rust/nix#1743 (comment) .
bors added a commit to rust-lang/libc that referenced this pull request Oct 10, 2022
@bors
Auto merge of #2951 - MrCroxx:xx/bump-to-135, r=JohnTitor
88b2ed2 
Bump to 0.2.135

I'm going to make a new release as requested by nix-rust/nix#1743 (comment) .
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 10, 2022 

ℹ️ [Scheduling was delayed due to a concurrency limit on community tasks](https://cirrus-ci.org/faq/#are-there-any-limits)
ℹ️ [Consider upgrading to a $10/month plan to get 2x the limits on any public and private repository](https://github.com/marketplace/cirrus-ci/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW45OTI=#pricing-and-setup)

🤣

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 11, 2022

@asomers Any plan to increase CI quota?

@SteveLauC
Copy link
Member

CI looks recovered, try adding a new commit

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 11, 2022

CI passed, PTAL. 🥰

@rtzoeller
Copy link
Collaborator

@MrCroxx can you squash these changes down to a single commit? Changes look reasonable, thanks!

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 13, 2022

@MrCroxx can you squash these changes down to a single commit? Changes look reasonable, thanks!

Sure.

rtzoeller
rtzoeller approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

Build succeeded:

@bors bors bot merged commit 3f637de into nix-rust:master Oct 13, 2022
@MrCroxx MrCroxx deleted the xx/xfs-super-number branch November 3, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add XFS_SUPER_MAGIC: FsType
4 participants
@MrCroxx @asomers @SteveLauC @rtzoeller