Change gethostname to use a buffer of MaybeUninit values #1745
Conversation
nathaniel-daniel
force-pushed
the
maybeuninit-gethostname
branch
2 times, most recently
from
87b7bb3
to
b47686e
Compare
|
Certainly an improvement. But wouldn't it be even better if it just returned an owned string, like what |
|
I actually am using this for in a wrapper that returns an owned string. I wasn't sure if changing this to only work for owned strings would be an improvement, as its technically possible to take the user-created buffer and unsafely make it owned with the length data from the returned c-string. This method also allows users to use buffers they may already have. Making this wrapper work only for owned strings would be the most convenient for me, but it would break use cases where the user already has a buffer. I wasn't sure if such a change would be accepted, so I opted to make the simplest, least controversial change. I would be willing to change my PR so that it only works for owned buffers if that is deemed important. |
|
I think owned strings would be most convenient for everybody. It wouldn't be the most performant option, but how many people rely on maximum performance for |
|
Fair enough. I've updated the PR to return an |
|
CI failures seem to be due to |
|
@nathaniel-daniel it should be fixed if you rebase! |
nathaniel-daniel
force-pushed
the
maybeuninit-gethostname
branch
from
7710fb6
to
22c4ba8
Compare
|
Rebased |
Changing
gethostnameto accept a buffer ofMaybeUninitbytes allows the user to avoid needlessly initializing a buffer. This is a breaking API change.