-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getrusage wrapper #1747
Add getrusage wrapper #1747
Conversation
88defff
to
83927a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you add a note to the changelog linking back to this PR (squashed into the current commit)?
Is this how it is usually done? I found it in the history but it seemed to be always done by a bot or something?
|
We use a tool called bors to ensure PRs merged at the same time don't break the build. I believe this was what you were referring to. The CHANGELOG.md updates are made manually though; can you modify CHANGELOG.md, similar to this PR? Ideally the changelog is modified in the same commit as the existing one, because bors won't squash the commit history when merging. |
Oh, I thought you meant the commit message, didn't notice there was a changelog. On it! |
Includes an enum to specify what to get resource usage for, and a new struct that provides a more readable view into libc::rusage, including using TimeVal for user and system CPU time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Includes an enum to specify what to get resource usage for, and a new
struct that provides a more readable view into libc::rusage, including
using TimeVal for user and system CPU time.
Signed-off-by: Gustavo Noronha Silva gustavo@noronha.dev.br