Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Statfs::flags method #1849

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Add a Statfs::flags method #1849

merged 4 commits into from
Oct 24, 2022

Conversation

asomers
Copy link
Member

@asomers asomers commented Oct 18, 2022

It returns the mount flags on the BSDs. On Linux, it returns a slightly different set of flags.

CHANGELOG.md Outdated
([#1849](https://github.com/nix-rust/nix/pull/1849))
- Added a 'Statfs::flags' method.
([#1849](https://github.com/nix-rust/nix/pull/1849))
- Added a 'Statfs::flags' method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate entries?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really weird. Must've happened when I reordered my commits. And the weirdest part is that I couldn't make it go away by creating a second commit that removed the dupe and combining it as a fixup with the first commit. But I finally got it fixed.

Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the changelog being fixed to only have one new entry.

It returns the mount flags on the BSDs.  On Linux, it returns a slightly
different set of flags.
@asomers
Copy link
Member Author

asomers commented Oct 24, 2022

bors r=rtzoeller

@bors bors bot merged commit 20df092 into nix-rust:master Oct 24, 2022
@asomers asomers deleted the stats-flags branch October 24, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants