Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: 0.24.3 #1889

Merged
merged 16 commits into from
Dec 2, 2022
Merged

Preview: 0.24.3 #1889

merged 16 commits into from
Dec 2, 2022

Commits on Nov 29, 2022

  1. Reset changelog

    rtzoeller committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b8fec71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a94fc9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8f291e9 View commit details
    Browse the repository at this point in the history
  4. Handle unacceptable name gracefully in {User,Group}::from_name

    Calling `unwrap` on the result of `CString::new` may cause the current
    thread to panic, which is a bit surprising undocumented behavior. It
    would be more reasonable to treat the erroneous name as a non-existing
    user or group.
    magicant authored and rtzoeller committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    6ea2d3f View commit details
    Browse the repository at this point in the history
  5. fix crash on Android platform

    wdsgyj authored and rtzoeller committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    cfacd8f View commit details
    Browse the repository at this point in the history
  6. Fix using SockaddrStorage to store Unix domain addresses on Linux

    Since it has variable length, the user of a sockaddr_un must keep track
    of its true length.  On the BSDs, this is handled by the builtin sun_len
    field.  But on Linux-like operating systems it isn't.  Fix this bug by
    explicitly tracking it for SockaddrStorage just like we already do for
    UnixAddr.
    
    Fixes nix-rust#1866
    asomers authored and rtzoeller committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    c77458f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Fix UB in the SO_TYPE sockopt

    When reading a value into an enum from getsockopt, we must validate it.
    Failing to do so can lead to UB for example with SOCK_PACKET on Linux.
    
    Perform the validation in GetSockOpt::get.  Currently SockType is the
    only type that requires validation.
    
    Fixes nix-rust#1819
    asomers authored and rtzoeller committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2c58cf7 View commit details
    Browse the repository at this point in the history
  2. Update use of libc::timespec to prepare for future libc version

    This is a backport of 006fc6f. The
    original commit message follows:
    
    In a future release of the `libc` crate, `libc::timespec` will contain
    private padding fields on `*-linux-musl` targets and so the struct will
    no longer be able to be created using the literal initialization syntax.
    
    Update places where `libc::timespec` is created to first zero initialize
    the value and then update the `tv_sec` and `tv_nsec` fields manually.
    Many of these places are in `const fn`s so a helper function
    `zero_init_timespec()` is introduced to help with this as
    `std::mem::MaybeUninit::zeroed()` is not a `const` function.
    
    Some matches on `libc::timespec` are also updated to include a trailing
    `..` pattern which works when `libc::timespec` has additional, private
    fields as well as when it does not (like for
    `x86_64-unknown-linux-gnu`).
    wesleywiser authored and rtzoeller committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    fbf8ffc View commit details
    Browse the repository at this point in the history
  3. Clippy cleanup

    asomers authored and rtzoeller committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    9a4ca6e View commit details
    Browse the repository at this point in the history
  4. Fix clippy warnings on nightly

    Clippy is now smarter about detecting unnecessary casts and
    useless conversions, which means we need to be more explicit
    about when the conversions are needed for a subset of platforms.
    
    Required changes found by repeatedly running the following command
    against a list of the supported platforms.
    
    `xargs -t -I {} sh -c "cargo clippy -Zbuild-std --target {} --all-targets -- -D warnings || exit 255"`
    
    I removed the casts it complained about, and then restored them
    with an `#[allow]` if a later target needed the cast.
    rtzoeller committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1274987 View commit details
    Browse the repository at this point in the history
  5. Fix a new clippy lint

    asomers authored and rtzoeller committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    83e77a3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3fd7fb1 View commit details
    Browse the repository at this point in the history
  7. Run a round of clippy to fix CI

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    SUPERCILEX authored and rtzoeller committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    3731613 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f87ea28 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e2da04a View commit details
    Browse the repository at this point in the history
  10. Pin older version of cargo-hack

    This works around a MSRV error.
    rtzoeller committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b66efce View commit details
    Browse the repository at this point in the history