Initial wasi/wasm support for fs, uio, zerocopy #2011
+281
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
commented
Mar 7, 2023
connor4312
commented
Mar 7, 2023
connor4312
force-pushed
the
master
branch
2 times, most recently
from
c678a4a
to
8cf83f3
Compare
|
Looks like build failure is a flake |
|
I guess these changes could also be applied to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #786
Depends on rust-lang/libc#3143, hence marking as a draft.DoneThis implements WASI support sufficient to build the fs, uio, and zerocopy features (enough to build coreutils 🙂)
Lots of stuff is flagged out since file permissions aren't present in
wasi_snapshot_preview1which is what rust supports out of the box forwasm32-wasi.One kind of weird thing is dealing with
PATH_MAX. WASI doesn't define one, it's whatever the host system is, but afaik there's not an API to get this. So for WASI I defaulted to libc's "linux_like" value of 4096. Let me know what you think.