Add SockProtocol variants for ICMP{,v6}
#2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnaaman-dn
force-pushed
the
add-icmp
branch
5 times, most recently
from
4c95612
to
bc52d14
Compare
asomers
requested changes
Aug 26, 2023
gnaaman-dn
force-pushed
the
add-icmp
branch
4 times, most recently
from
225de32
to
de9361a
Compare
|
👍 These also work for creating unprivileged ICMP{,v6} sockets using SOCK_DGRAM on Linux and macOS -- not sure if that helps the testing situation at all (sounds like not really)? Looks like work has stalled a tiny bit -- anything I can do to help get this over the line? |
Bump received, thanks!
Friendly ping @asomers, can I trouble you for another review on this PR, it seems that the test using raw socket is done, and the request changes are resolved hi, @gnaaman-dn Would you like to rebase your branch to resolve the conflict, thanks! |
|
Sure can :) |
asomers
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanRaw/KextEventhave the same value asICMP, which means one of them has to be a constant.I chose to make
CanRaw&KextEventconstants since as far as I can tell,Icmpis always present (similar to Udp/Tcp, etc).I started writing a test that sends an Echo-Request, but opening an ICMP/Raw socket requires root permissions, so I'm not sure if it's fit as a test.