Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: tweak test_fanotify() to monitor ONLY 1 file #2294

Merged

Conversation

SteveLauC
Copy link
Member

What does this PR do

Tweak test_fanotify() to make it monitor ONLY 1 file rather than the whole mount point.

For more info, see this comment.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC
Copy link
Member Author

SteveLauC commented Jan 16, 2024

I have tested this locally, though I still think we should merge #2269 first to see CI's reaction to this change:

$ git status
On branch test_fanotify_monitor_only_one_file
Your branch is up to date with 'origin/test_fanotify_monitor_only_one_file'.

nothing to commit, working tree clean

$ sudo --preserve-env=HOME $(which cargo) test sys::test_fanotify::test_fanotify --all-features
    Finished test [unoptimized + debuginfo] target(s) in 0.03s
     Running unittests src/lib.rs (target/debug/deps/nix-df3c717de9b67128)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 19 filtered out; finished in 0.00s

     Running test/test.rs (target/debug/deps/test-64b011f0c61ee152)

running 1 test
test sys::test_fanotify::test_fanotify ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 351 filtered out; finished in 0.00s

@SteveLauC SteveLauC mentioned this pull request Feb 6, 2024
3 tasks
@SteveLauC
Copy link
Member Author

Merge this to fix the partial CI error of #2269

@SteveLauC SteveLauC added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@SteveLauC SteveLauC added this pull request to the merge queue Feb 6, 2024
Merged via the queue into nix-rust:master with commit 0dfcf32 Feb 6, 2024
35 checks passed
@SteveLauC SteveLauC deleted the test_fanotify_monitor_only_one_file branch February 6, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants