mqueue: change types to allow more cases

[abbradar]

Part of #270, fixed according to @kamalmarhubi's comments.

[kamalmarhubi]

@homu r+

[homu]

📌 Commit 62ec478 has been approved by kamalmarhubi

[homu]

⌛ Testing commit 62ec478 with merge f2343cd...

[kamalmarhubi]

Looks like I led you astray suggesting as *const _, and you'll need the full type. :/

[abbradar]

Hm, why had it compiled for me? I use Rust unstable (coming from Haskell also, we have partial type signatures there so I wasn't on guard).

[kamalmarhubi]

@abbradar are you on OS X? Looks like it even failed on nightly on Linux: https://travis-ci.org/nix-rust/nix/jobs/110474199

[kamalmarhubi]

Oh the nightly failures are different. Interesting.

[abbradar]

No, on Linux -- just tried setting i32 instead of _ and it (EDIT) hasn't worked for me. I use very fresh nightly -- from several days ago, so maybe they have improved type inference.

[kamalmarhubi]

@homu retry

[homu]

⌛ Testing commit 62ec478 with merge 48aa78b...

[kamalmarhubi]

@homu r+

[homu]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: mqueue: change types to allow more cases #271

[homu]

📌 Commit 62ec478 has been approved by kamalmarhubi

[homu]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: mqueue: change types to allow more cases #271

[kamalmarhubi]

@homu r-

[kamalmarhubi]

@homu r+

[homu]

📌 Commit 62ec478 has been approved by kamalmarhubi

[kamalmarhubi]

(Sorry for the noise, new to @homu around here!)

[abbradar]

I have a fix with a fully specified type ready, so if she fails I'll force-push it and have you know.

[homu]

💡 This pull request was already approved, no need to approve it again.

[homu]

💡 This pull request was already approved, no need to approve it again.

[kamalmarhubi]

@homu retry

[homu]

⌛ Testing commit 62ec478 with merge 68fe26b...

[abbradar]

I've force-pushed the version with full type specification. Let's try it!

[kamalmarhubi]

@homu retry

[kamalmarhubi]

I think I've confused @homu on this one.

[kamalmarhubi]

Oh right, it unapproves if the PR changes.

@homu r+ 05f933b

[kamalmarhubi]

Looks like you need to fix uses in test/test_mq.rs?

[abbradar]

Yeah, I've learnt to use cargo test only now ^_^". Sorry, fixed that.

[kamalmarhubi]

@homu retry

[kamalmarhubi]

@homu r+ 8ca6d82

[abbradar]

@homu keeps silent for some reason -- should she be like this?

[homu]

⌛ Testing commit 8ca6d82 with merge 6cad03a...

[homu]

☀️ Test successful - status