-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fcntl: Use bindings from libc instead of our own #354
Conversation
Hi @brianp, thanks for the PR! Taking a look now! |
Oh re |
pub const F_SETLK: c_int = 6; | ||
pub const F_SETLKW: c_int = 7; | ||
pub const F_GETLK: c_int = 5; | ||
use libc::{c_int}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for braces if just importing one name
I think if you make the change with the |
Thanks for the reply. If I can help out with rust-lang/libc#235 in any way let me know! I'll tidy up this pr but will still leave |
#[cfg(target_os = "netbsd")] | ||
pub const F_SETNOSIGPIPE: c_int = 14; | ||
} | ||
pub const F_ADD_SEALS: c_int = 1033; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a TODO explaining why these are left here, and reference rust-lang/libc#235
one small comment, otherwise this looks good. could you squash your commits down so we don't have the broken one in our history? |
Happy to! I'll take care of it now. |
fcntl: Use bindings from libc instead of our own **Un-finished** and looking for help. As #264 was tagged "mentor, good first bug" Ref #264 I couldn't find `F_GET_SEALS`, or `F_ADD_SEALS` in libc. Is this a case where I should be making a PR over there? I'm not sure where exactly to address it in libc.
☀️ Test successful - status |
Un-finished and looking for help. As #264 was tagged "mentor, good first bug"
Ref #264
I couldn't find
F_GET_SEALS
, orF_ADD_SEALS
in libc.Is this a case where I should be making a PR over there? I'm not sure where exactly to address it in libc.