Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove thread parallelism #539

Closed

Conversation

posborne
Copy link
Member

Fixes #529, also refer to
#529 which first added this
for the old CI infrastructure.

Fixes nix-rust#529, also refer to
nix-rust#529 which first added this
for the old CI infrastructure.

Signed-off-by: Paul Osborne <osbpau@gmail.com>
@fiveop
Copy link
Contributor

fiveop commented Feb 27, 2017

You meantion the same issue twice. Do you want me to homu r+ this? Or do you just want to merge this stuff yourself?

@posborne
Copy link
Member Author

r+ is fine. It doesn't look like this is enough to resolve all issues on its own, so I'm still investigating. I need to update this as well as it should be CARGO_TEST_THREADS

@fiveop
Copy link
Contributor

fiveop commented Feb 27, 2017

Your answer confuses me. But @homu r+

@homu
Copy link
Contributor

homu commented Feb 27, 2017

📌 Commit d0a151b has been approved by fiveop

homu added a commit that referenced this pull request Feb 27, 2017
ci: remove thread parallelism

Fixes #529, also refer to
#529 which first added this
for the old CI infrastructure.
@homu
Copy link
Contributor

homu commented Feb 27, 2017

⌛ Testing commit d0a151b with merge 01ccd59...

@posborne
Copy link
Member Author

@homu r-

@homu
Copy link
Contributor

homu commented Feb 27, 2017

💥 Test timed out

@kamalmarhubi
Copy link
Member

@posborne can you double check the issue references in your PR / commit message?

@homu
Copy link
Contributor

homu commented Apr 8, 2017

☔ The latest upstream changes (presumably c3d5eda) made this pull request unmergeable. Please resolve the merge conflicts.

@Susurrus Susurrus force-pushed the new-ci/master branch 3 times, most recently from c192289 to a076c7f Compare April 15, 2017 17:33
@Susurrus
Copy link
Contributor

Have we figured out if this is still necessary?

@asomers
Copy link
Member

asomers commented Apr 17, 2017

I think that PR #579 fixes the root problem in a better way. At least, it does for now.

@Susurrus
Copy link
Contributor

But it didn't change anything in CI, so I guess we're still trying to figure out the root of those errors, yes?

@asomers
Copy link
Member

asomers commented Apr 17, 2017

Correct. I don't know why those tests are still failing in CI.

@Susurrus
Copy link
Contributor

Then let's close this PR in favor of a separate issue to figure that out.

@Susurrus Susurrus closed this Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants