Add all Android targets as Tier 3 platforms #639
Conversation
README.md
Outdated
| @@ -42,6 +42,9 @@ limitations. Support for platforms is split into two tiers: | |||
| * Tier 2 - Builds for this target are run in CI. Failures during the build | |||
| blocks the inclusion of new code. Tests may be run, but failures | |||
| in tests don't block the inclusion of new code. | |||
| * Tier 3 - Builds for this target are un in CI. Failures during the build | |||
|
I would like to see Android move toward being a higher tier (at least 2 but hopefully tier 1 eventually) platform over time as I will have the need to use nix on these platforms as part of my day job but this seems like the pragmatic move for now. |
There was a problem hiding this comment.
@Susurrus I'm curious: why did you include i686 Android but not x86_64 Android? I would've thought that by now the latter would be more important.
@posborne do you know of any testing service that runs on Android? According to https://github.com/japaric/cross , QEMU doesn't work for it. Without either QEMU or a testing service, we can't promote it to Tier 1.
.travis.yml
Outdated
| @@ -77,6 +87,16 @@ matrix: | |||
| # Testing nightlies on main targets. These might fail because of issues | |||
Susurrus
force-pushed
the
add_android_builds
branch
from
6c91686
to
38e8318
Compare
|
@asomers Skipping @posborne While having all of these platforms Tier 1 is the goal, they first need to get to Tier 3 and regularly part of CI as a step towards that. Additionally, there is work with trust/cross to add test support for Android, so hopefully we won't have to do much special besides continue to test those systems. Thanks for the feedback, I've updated things accordingly, so we'll see if Travis is indeed fixed. |
|
@asomers libc is testing on Android using Docker and QEMU, maybe we could try to use the same method. |
With the previous docker containers, we had this going. I don't think the tests were passing, but it should be possible. Getting the Android artifacts into the container is a little bit hairy but there should be plenty of prior art that exists (other docker containers doing similar stuff). |
|
Let's defer on discussion of how to move Android past Tier 1 until later. I'd like to get this merged as it's blocking #631. bors r+ |
Build succeeded |
cc @ndusart @roblabla