Add more platforms to CI #986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susurrus
force-pushed
the
more_platforms
branch
from
bea6867
to
eaf9440
Compare
|
Not certain why these weren't working by just adding them. Tried hacking them in, but need to come back and relearn our CI setup to actually get these fixed. |
|
Don't forget to add new platforms to the README, if we're going to support them. |
* aarch64-unknown-linux-musl * sparc64-unknown-linux-gnu * x86_64-unknown-linux-gnux32 These don't pass yet, but should be supportable by `nix`, so let's add them now so we can move towards fully supporting them.
|
Coming back to this now, so rebased and updated the CHANGELOG and README, but will likely wait until #1035 is merged to really dig into why these platforms are failing. |
|
Close this PR for the same reason as #2255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't pass yet, but should be supportable by
nix, so let's add them now as platforms that are allowed to fail so we can move towards fully supporting them.