Mark action as failed on error in minification process #3
Assignees
Labels
enhancement
New feature or request
Comments
|
Hello @C0pyR1ght ( : You are totally right! I will get to work on that as soon as possible. Thank you for the issue and the recommendation :D I'll keep track of this issue in my commits and pull requests so you can see the progress ( : |
nizarmah
added a commit
that referenced
this issue
Apr 21, 2020
Added certain functions to minify a file based on its type. Separated the minify function from the command used to minify the file. This will make it easier to deal with the issue #3 and throw an error once a command returns an error and doesn't run successfully.
|
Alright, so here's a quick update. I implemented the code necessary. I just need to launch a Docker image and test it for myself. Once it passes the tests I want, I'll pull and update the action! ( : |
|
Testing Log can be found in Auto-Minify-Test/Issues#3.
|
|
Alright, updated the action in the marketplace. Use the latest version, Thanks a lot for the recommendation! |
|
Kindly let me know if there is anything other way I can improve the Action 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it would be helpful to set the action as failed if for example a
Parse erroroccurs during minification process because the scoped files are not actually minified and therefore the goal not reached.Several Times I had some minor typos within the files to me minified that lead to a
Parse error. Therefore the file was obviously not commited to the repo but the action was always marked assuccessfullwhich is very missleading. You have to manually dive through the action logs to discover the failed minification process.The text was updated successfully, but these errors were encountered: