This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Float formating under locale #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
Thanks @challet this looks good! |
2 similar comments
|
Many thanks for the quick merge @njbarrett! |
|
@FelixMalfait yes no problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #90, here is a patch proposal to deal with float formating.
WKT is actually a string representation, but should remain independant from any locale format.
An other approcah would have been to skip the WKT layer and to bind directly the float values in a prepared statement. I cannot say for now how it might be done with Eloquent (several bindings for one column).