Skip to content
This repository has been archived by the owner on Jul 29, 2021. It is now read-only.

Commit

Permalink
Deleted Freebase code
Browse files Browse the repository at this point in the history
Freebase is long-gone
  • Loading branch information
njh committed Oct 5, 2018
1 parent b75e453 commit 23832a5
Show file tree
Hide file tree
Showing 11 changed files with 3 additions and 450 deletions.
7 changes: 0 additions & 7 deletions dbpedialite.rb
Expand Up @@ -193,13 +193,6 @@ def format_iso8061(datetime)
redirect_from_title($2)
elsif params[:url] =~ %r{^https?://(www\.)?wikidata.org/(wiki|entity)/(Q\d+)$}
redirect_from_wikidata($3)
elsif params[:url] =~ %r{^https?://www.freebase.com/(view|inspect|edit/topic)(/.+)$}
begin
data = FreebaseApi.lookup_by_id($2)
redirect "/things/#{data['key']['value']}", 301
rescue FreebaseApi::NotFound
not_found("No Wikipedia page id found for Freebase topic")
end
elsif params[:url] =~ %r{^https?://([\w\.\-\:]+)/(things|categories)/(\d+)(\#\w*)?$}
begin
data = WikipediaApi.page_info(:pageids => $3)
Expand Down
83 changes: 0 additions & 83 deletions lib/freebase_api.rb

This file was deleted.

48 changes: 0 additions & 48 deletions lib/thing.rb
@@ -1,6 +1,5 @@
require 'wikipedia_api'
require 'wikidata_api'
require 'freebase_api'
require 'base_model'


Expand All @@ -12,8 +11,6 @@ class Thing < BaseModel
has :latitude, :kind => Float, :default => nil
has :externallinks, :kind => Array, :default => []
has :updated_at, :kind => DateTime, :default => nil
has :freebase_guid, :kind => String, :default => nil
has :freebase_mid, :kind => String, :default => nil
has :wikidata_id, :kind => String, :default => nil
has :wikidata_label, :kind => String, :default => nil
has :wikidata_description, :kind => String, :default => nil
Expand All @@ -34,49 +31,6 @@ def load
#end
end

def freebase_guid
fetch_freebase_uris
@freebase_guid
end

def freebase_mid
fetch_freebase_uris
@freebase_mid
end

def freebase_guid_uri
fetch_freebase_uris
if freebase_guid
@freebase_guid_uri ||= RDF::URI.parse("http://rdf.freebase.com/ns/"+freebase_guid.sub('#','guid.'))
end
end

def freebase_mid_uri
fetch_freebase_uris
if freebase_mid
@freebase_mid_uri ||= RDF::URI.parse("http://rdf.freebase.com/ns/"+freebase_mid.sub('/m/','m.'))
end
end

def fetch_freebase_uris
# Only make call to freebase once
unless @called_freebase
@called_freebase = true
# Attempt to match to Freebase, but silently fail on error
begin
data = FreebaseApi.lookup_wikipedia_pageid(pageid)
self.freebase_mid = data['mid']
self.freebase_guid = data['guid']
rescue Timeout::Error => e
$stderr.puts "Timed out while reading from Freebase: #{e.message}"
rescue FreebaseApi::Exception => e
$stderr.puts "Error while reading from Freebase: #{e.message}"
rescue Net::HTTPServerException => e
$stderr.puts "Error while making HTTP request to Freebase: #{e.message}"
end
end
end

def wikidata_id
fetch_wikidata
@wikidata_id
Expand Down Expand Up @@ -143,8 +97,6 @@ def to_rdf
graph << [self.uri, RDF::RDFS.comment, abstract]
graph << [self.uri, RDF::FOAF.isPrimaryTopicOf, wikipedia_uri]
graph << [self.uri, RDF::OWL.sameAs, dbpedia_uri]
graph << [self.uri, RDF::OWL.sameAs, freebase_guid_uri] unless freebase_guid_uri.nil?
graph << [self.uri, RDF::OWL.sameAs, freebase_mid_uri] unless freebase_mid_uri.nil?
graph << [self.uri, RDF::GEO.lat, latitude] unless latitude.nil?
graph << [self.uri, RDF::GEO.long, longitude] unless longitude.nil?

Expand Down
42 changes: 1 addition & 41 deletions spec/dbpedialite_spec.rb
Expand Up @@ -258,11 +258,6 @@ def app
:body => fixture_data('wbgetentities-ceres.json'),
:content_type => 'application/json'
)
FakeWeb.register_uri(
:get, %r[https://www.googleapis.com/freebase/v1/mqlread],
:body => fixture_data('freebase-mqlread-934787.json'),
:content_type => 'application/json'
)
end

context "as an HTML document using content negotiation" do
Expand Down Expand Up @@ -292,11 +287,6 @@ def app
:body => fixture_data('parse-934787.json'),
:content_type => 'application/json'
)
FakeWeb.register_uri(
:get, %r[http://api.freebase.com/api/service/mqlread],
:body => fixture_data('freebase-mqlread-934787.json'),
:content_type => 'application/json'
)
header "Accept", "text/plain"
get '/things/934787'
end
Expand Down Expand Up @@ -449,11 +439,6 @@ def app
:body => fixture_data('wbgetentities-imac.json'),
:content_type => 'application/json'
)
FakeWeb.register_uri(
:get, %r[https://www.googleapis.com/freebase/v1/mqlread],
:body => fixture_data('freebase-mqlread-21492980.json'),
:content_type => 'application/json'
)
end

context "as an HTML document" do
Expand Down Expand Up @@ -518,7 +503,7 @@ def app
end
end

context "GETing an HTML thing for something that doesn't exist in Freebase or Wikidata" do
context "GETing an HTML thing for something that doesn't exist in Wikidata" do
before :each do
FakeWeb.register_uri(
:get, 'https://en.wikipedia.org/w/api.php?action=parse&format=json&pageid=2008435&prop=text%7Cdisplaytitle',
Expand All @@ -530,11 +515,6 @@ def app
:body => fixture_data('wbgetentities-notfound.json'),
:content_type => 'application/json'
)
FakeWeb.register_uri(
:get, %r[https://www.googleapis.com/freebase/v1/mqlread],
:body => fixture_data('freebase-mqlread-notfound.json'),
:content_type => 'application/json'
)
@stderr_buffer = StringIO.new
previous_stderr, $stderr = $stderr, @stderr_buffer
get '/things/2008435'
Expand Down Expand Up @@ -740,26 +720,6 @@ def app
end
end

context "flipping from a Freebase page" do
before :each do
FakeWeb.register_uri(
:get, %r[https://www.googleapis.com/freebase/v1/mqlread],
:body => fixture_data('freebase-mqlread-en-new-york.json'),
:content_type => 'application/json'
)
get '/flipr?url=http%3A%2F%2Fwww.freebase.com%2Fview%2Fen%2Fnew_york'
end

it "should redirect to the coresponding Dbpedia lite thing page" do
last_response.status.should == 301
last_response.location.should == 'http://example.org/things/645042'
end

it "should be cachable" do
last_response.headers['Cache-Control'].should =~ /max-age=([1-9]+)/
end
end

context "flipping from an unknown page" do
before :each do
get '/flipr?url=http%3A%2F%2Fwww.bbc.co.uk%2F'
Expand Down
9 changes: 0 additions & 9 deletions spec/fixtures/freebase-mqlread-21492980.json

This file was deleted.

9 changes: 0 additions & 9 deletions spec/fixtures/freebase-mqlread-934787.json

This file was deleted.

12 changes: 0 additions & 12 deletions spec/fixtures/freebase-mqlread-en-new-york.json

This file was deleted.

13 changes: 0 additions & 13 deletions spec/fixtures/freebase-mqlread-invalid.json

This file was deleted.

3 changes: 0 additions & 3 deletions spec/fixtures/freebase-mqlread-notfound.json

This file was deleted.

0 comments on commit 23832a5

Please sign in to comment.