Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client#publish should reject blank topics with a sensible error message #47

Closed
michaelklishin opened this issue Jun 27, 2014 · 1 comment
Closed

Client#publish should reject blank topics with a sensible error message #47

michaelklishin opened this issue Jun 27, 2014 · 1 comment

Comments

@michaelklishin
Copy link
Contributor

Right now publishing to an empty topic (by mistake) results in

mqtt/packet.rb:309:in `encode_body': Invalid topic name when serialising packet (RuntimeError)

It clearly should be an ArgumentError.
@njh
Copy link
Owner

njh commented Jun 28, 2014

Will look into this. Also just noticed that the payload parameter should be optional.

@njh njh closed this as completed in 590e323 Jun 28, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @njh