WIP: refactor to comply python3.8 and python3.9 #226
Conversation
HerrMuellerluedenscheid
force-pushed
the
feature/py38-refactor
branch
from
c49e1ab
to
8da749a
Compare
|
Great to see, that someone's working on a compatible version for Python versions >3.8. |
|
I'm on vacation til the end of the week and will hopefully find the time to look into this next week. A few additional errors were raised within the unit test which I need to have a closer look at. |
HerrMuellerluedenscheid
force-pushed
the
feature/py38-refactor
branch
from
8da749a
to
f4cbe60
Compare
|
Hey, just curious.. I'm eagerly waiting for this PR to be merged.. Is the PR ready to be merged?? Thanks |
|
It's not ready, yet. The tests do not succeed yet because of previously introduced hiccups that need to be resolved on master beforehand, I guess. |
|
Depends on #231 |
…s0, race conditions on detached sessions, eliminated set_exception on client disconnect tasks, a few debug log message isEnabledFor wrappers." This reverts commit 1f5efd3.
HerrMuellerluedenscheid
force-pushed
the
feature/py38-refactor
branch
from
6361e4d
to
6a021a5
Compare
|
Tests pass for python 3.6, 3.7, 3.8 and 3.9 after reverting as discussed in #231. |
HerrMuellerluedenscheid
changed the title
|
Hey @HerrMuellerluedenscheid is this PR ready to be merged? I saw your other PR's (#228, #229) and Issue (#235) & I don't think @njouanin is ready to act on those.. If this PR is ready I would like to merge this into my own Fork.. Thanks. |
Hey @pavandv , |
|
Hey @HerrMuellerluedenscheid as this is not maintained anymore, what is the status on this?? |
|
@pavandv hey, i continued the branch there: Yakifo/amqtt#18 it does not contain changes compared to this branch for the actual code, just tests. |
No description provided.